Pass arguments to memoized callback in useAsync #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently no arguments are passed into the memoized callback. This means the use of an async function that requires arguments isn't possible. For instance;
```
const fetchItems = async function(searchTerm) {
return (await fetch(`/api/items?q=${searchTerm}`)).json();
};
function Results({ searchTerm }) {
const { value } = useAsync(fetchItems, [searchTerm]);
// shows results
return (
<ul/>
);
}
```
As stated in the `useCallback` [docs][1], the array of inputs as used on ln 24 is not passed as arguments, they must be passed when the memoized function is called.
> Note
> The array of inputs is not passed as arguments to the callback. Conceptually, though, that’s what they represent: every value referenced inside the callback should also appear in the inputs array. In the future, a sufficiently advanced compiler could create this array automatically.
This change passes the arguments to the memoized function.
[1]: https://reactjs.org/docs/hooks-reference.html#usecallback
Jivings
changed the title
streamich
pushed a commit
that referenced
this pull request
Dec 19, 2018
# [5.1.0](v5.0.0...v5.1.0) (2018-12-19) ### Bug Fixes * 🐛 just use any for setTimeout because of diff environments ([55673cb](55673cb)) * 🐛 memoized does not receive arguments ([244a533](244a533)) * 🐛 use Timeout type for build to work ([8c66abe](8c66abe)) ### Features * added useDebounce ([91ff6ba](91ff6ba)) * pass arguments to memoized callback ([#81](#81)) ([88dd513](88dd513))
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi, looks like the fix was reverted: didn't it work or was it accidentally ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently no arguments are passed into the memoized callback. This means the use of an async function that requires arguments isn't possible. For instance;
searchTermin thefetchItemsfunction will beundefined.As stated in the
useCallbackdocs, the array of inputs as used on ln 24 is not passed as arguments, they must be passed when the memoized function is called.This change passes the arguments to the memoized function.