Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1646 #1738

Merged
merged 1 commit into from
Jan 8, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: #1646
make own interface that compatible with GeolocationPositionError and PositionError.

It is the easiest way to avoid errors in typescript 4.1
  • Loading branch information
xobotyi committed Jan 8, 2021
commit ebc7094bbc156be57b3de855c6984c1d056cf0e6
17 changes: 15 additions & 2 deletions src/useGeolocation.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
import { useEffect, useState } from 'react';

/**
* @desc Made compatible with {GeolocationPositionError} and {PositionError} cause
* PositionError been renamed to GeolocationPositionError in typescript 4.1.x and making
* own compatible interface is most easiest way to avoid errors.
*/
export interface IGeolocationPositionError {
readonly code: number;
readonly message: string;
readonly PERMISSION_DENIED: number;
readonly POSITION_UNAVAILABLE: number;
readonly TIMEOUT: number;
}

export interface GeoLocationSensorState {
loading: boolean;
accuracy: number | null;
Expand All @@ -10,7 +23,7 @@ export interface GeoLocationSensorState {
longitude: number | null;
speed: number | null;
timestamp: number | null;
error?: Error | PositionError;
error?: Error | IGeolocationPositionError;
}

const useGeolocation = (options?: PositionOptions): GeoLocationSensorState => {
Expand Down Expand Up @@ -43,7 +56,7 @@ const useGeolocation = (options?: PositionOptions): GeoLocationSensorState => {
});
}
};
const onEventError = (error: PositionError) =>
const onEventError = (error: IGeolocationPositionError) =>
mounted && setState((oldState) => ({ ...oldState, loading: false, error }));

useEffect(() => {
Expand Down