fix: useUpdateEffect run on the wrong time

streamich · Aug 12, 2019 · 1d5cd10 · 1d5cd10
1 parent 2ccde2f
commit 1d5cd10
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/src/useUpdateEffect.ts b/src/useUpdateEffect.ts
@@ -3,14 +3,13 @@ import { useEffect, useRef } from 'react';
 const useUpdateEffect: typeof useEffect = (effect, deps) => {
   const isInitialMount = useRef(true);
 
-  useEffect(
-    isInitialMount.current
-      ? () => {
-          isInitialMount.current = false;
-        }
-      : effect,
-    deps
-  );
+  useEffect(() => {
+    if (isInitialMount.current) {
+      isInitialMount.current = false;
+    } else {
+      effect();
+    }
+  }, deps);
 };
 
 export default useUpdateEffect;