Skip to content

feat(volume): add caseSensitive option #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Feb 9, 2021

Defaults to 'true'. If 'false', handle file names case insensitive.
Preserve original file names.

Fixes: #533

Defaults to 'true'. If 'false', handle file names case insensitive.
Preserve original file names.

Fixes: streamich#533
@G-Rath
Copy link
Collaborator

G-Rath commented Feb 9, 2021

I'll review this properly when I have a chance, but for now: I think I'd prefer this option to be ignoreCase with a default of false rather than have an option with a default of true as that tends to be easier to reason mentally.

@ajafff
Copy link
Contributor Author

ajafff commented Feb 10, 2021

@G-Rath that makes sense. I'll update the PR accordingly.

I noticed that the sorting of readdir(Sync) should also respect case sensitivity. I'm currently working on that.

I should probably also update the docs.

@tstordyallison
Copy link

+1 for this. I'm playing around with using memfs in conjunction with some libraries that are assuming case-insensitivity on Windows platforms, which isn't the case when I'm using memfs! This would be an ideal fix.

@jburrow
Copy link

jburrow commented Feb 22, 2021

+1 Just hit the same issue with memfs on windows

@G-Rath
Copy link
Collaborator

G-Rath commented Sep 15, 2023

Closing due to age - feel free to rebase this PR or open a new one if someone wants to pick it back up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for case sensitivity settings
4 participants