fix: Use cross-platform dirname instead of posix.dirname
#1194
+18
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
window-fix
branch
4 times, most recently
from
fe34f73 to
6cbc1ef
Compare
`posix.dirname` was being used in some places, which could cause incorrect behavior on Windows systems where path separators are different. This change replaces it with the cross-platform `dirname()` to ensure consistent path handling. This issue was introduced in commit da1388e. Closes streamich#1193
alan-agius4
force-pushed
the
window-fix
branch
from
6cbc1ef to
7a51ac3
Compare
william-wheate-pushgaming
approved these changes
Sep 23, 2025
|
🎉 This PR is included in version 4.43.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
posix.dirnamewas being used in some places, which could cause incorrect behavior on Windows systems where path separators are different. This change replaces it with the cross-platformdirname()to ensure consistent path handling.This issue was introduced in commit da1388e.
Closes #1193