feat: separate Node class into FileNode and DirNode classes #1182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the monolithic
Node
class into specializedFileNode
andDirNode
classes that inherit from a common abstractNode
base class, improving code organization and type safety.Changes Made
Node
base class: Contains common functionality like timestamps, permissions, mode, uid/gid, symlink support, and permission checksFileNode
class: ExtendsNode
with file-specific operations (getString()
,setString()
,getBuffer()
,setBuffer()
,write()
,read()
,truncate()
, and thebuf
property)DirNode
class: ExtendsNode
for directories (no buffer operations needed)Superblock.createNode()
to instantiate the appropriate node type based on file mode (S_IFDIR
→DirNode
, otherwise →FileNode
)FileNode
andDirNode
to module exports alongside the baseNode
classBenefits
FileNode
Node
classTesting
FileNode
)The implementation maintains full backward compatibility while providing a cleaner, more maintainable codebase structure.
Fixes #1181.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.