fix: 🐛 do not allow empty children names

streamich · Jun 17, 2023 · 43da1d6 · 43da1d6
1 parent 21bcbab
commit 43da1d6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/node-to-fsa/__tests__/NodeFileSystemDirectoryHandle.test.ts b/src/node-to-fsa/__tests__/NodeFileSystemDirectoryHandle.test.ts
@@ -270,6 +270,7 @@ onlyOnNode20('NodeFileSystemDirectoryHandle', () => {
     });
 
     const invalidNames = [
+      '',
       '.',
       '..',
       '/',
@@ -368,6 +369,7 @@ onlyOnNode20('NodeFileSystemDirectoryHandle', () => {
     });
 
     const invalidNames = [
+      '',
       '.',
       '..',
       '/',

diff --git a/src/node-to-fsa/util.ts b/src/node-to-fsa/util.ts
@@ -20,7 +20,7 @@ export const basename = (path: string, separator: string) => {
 const nameRegex = /^(\.{1,2})|(.*(\/|\\).*)$/;
 
 export const assertName = (name: string, method: string, klass: string) => {
-  const isInvalid = nameRegex.test(name);
+  const isInvalid = !name || nameRegex.test(name);
   if (isInvalid) throw new TypeError(`Failed to execute '${method}' on '${klass}': Name is not allowed.`);
 };