Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing older MSV components before build, OSN 29.1.3sl36 update #1467

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Installing older MSV components before build, OSN 29.1.3sl36 update #1467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31d7238
Installing older MSV components before build
avoitenko-logitech Jul 12, 2024
f98e8a2
Installing only necessary MSV components. OSN 29.1.3sl36
avoitenko-logitech Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:
SLGenerator: Visual Studio 17 2022
SLDistributeDirectory: distribute
SLFullDistributePath: "streamlabs-build.app/distribute" # The .app extension is required to run macOS tests correctly.
LibOBSVersion: 29.1.3sl34
LibOBSVersion: 29.1.3sl36
PACKAGE_NAME: osn

jobs:
Expand Down Expand Up @@ -129,6 +129,22 @@ jobs:
steps:
- name: 'Add msbuild to PATH'
uses: microsoft/setup-msbuild@v1
- name: Install older build components
run: |
# For versions update see here: https://learn.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-build-tools?view=vs-2022
Set-Location "C:\Program Files (x86)\Microsoft Visual Studio\Installer\"
$InstallPath = "C:\Program Files\Microsoft Visual Studio\2022\Enterprise"
$componentsToInstall= @(
"Microsoft.VisualStudio.Component.VC.v141.x86.x64"
"Microsoft.VisualStudio.Component.VC.14.39.17.9.x86.x64"
"Microsoft.VisualStudio.Component.VC.14.39.17.9.ATL"
)
[string]$workloadArgs = $componentsToInstall | ForEach-Object {" --add " + $_}
$Arguments = ('/c', "vs_installer.exe", 'modify', '--installPath', "`"$InstallPath`"",$workloadArgs, '--quiet', '--norestart', '--nocache')
# should be run twice
$process = Start-Process -FilePath cmd.exe -ArgumentList $Arguments -Wait -PassThru -WindowStyle Hidden
$process = Start-Process -FilePath cmd.exe -ArgumentList $Arguments -Wait -PassThru -WindowStyle Hidden
shell: powershell
- name: 'Checkout'
uses: actions/checkout@v3
with:
Expand All @@ -139,7 +155,7 @@ jobs:
shell: bash
- name: Install dependencies
run: |
yarn install --immutable --immutable-cache --check-cache
yarn install --immutable --immutable-cache --check-cache
yarn add electron@${{env.ElectronVersion}} -D
- name: Configure obs-studio-node
run: ./ci/configure-osn.cmd
Expand Down Expand Up @@ -186,7 +202,7 @@ jobs:
shell: bash
- name: Install dependencies
run: |
yarn install --immutable --immutable-cache --check-cache
yarn install --immutable --immutable-cache --check-cache
yarn add electron@${{env.ElectronVersion}} -D

- name: Get build from cache
Expand All @@ -207,7 +223,7 @@ jobs:
OSN_ACCESS_KEY_ID: ${{secrets.AWS_RELEASE_ACCESS_KEY_ID}}
OSN_SECRET_ACCESS_KEY: ${{secrets.AWS_RELEASE_SECRET_ACCESS_KEY}}
RELEASE_NAME: ${{matrix.ReleaseName}}
- name: Get the version of aws cli
- name: Get the version of aws cli
run: aws --version
shell: powershell
- name: Install specific version of AWS CLI
Expand Down
Loading