Fix GraphQL IDE charset error #3824

moritz89 · 2025-03-28T12:19:55Z

Description

Why:

Hide non-printing characters

This change addresses the need by:

Explicitly setting the content-type charset to utf-8

Types of Changes

Issues Fixed or Closed by This PR

Partial content-type results in GraphiQL formatting errors #3821

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Summary by Sourcery

Bug Fixes:

Resolve potential character encoding issues by explicitly setting the content type charset to UTF-8 in the GraphQL IDE handler

Why: - Hide non-printing characters This change addresses the need by: - Explicitly setting the content-type charset to utf-8

sourcery-ai · 2025-03-28T12:19:59Z

Reviewer's Guide by Sourcery

This pull request fixes a character encoding issue in the GraphQL IDE by explicitly setting the content type charset to utf-8. This ensures that non-printing characters are properly handled.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Set the content type charset to utf-8 for the GraphQL IDE response.	Set the `content_type` to `text/html; charset=utf-8`.	`strawberry/channels/handlers/http_handler.py`

Possibly linked issues

Partial content-type results in GraphiQL formatting errors #3821: The PR fixes the issue by setting the content-type header to text/html; charset=utf-8.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @moritz89 - I've reviewed your changes - here's some feedback:

Overall Comments:

Thanks for fixing this bug, explicitly setting the charset is the right approach.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

greptile-apps

PR Summary

This PR updates the async GraphQL IDE in http_handler.py to explicitly set the content-type header to "text/html; charset=utf-8", addressing formatting errors seen in GraphiQL (#3821).

In strawberry/channels/handlers/http_handler.py, render_graphql_ide() now returns "text/html; charset=utf-8" for async IDE responses.
The change resolves hidden character issues in GraphiQL without impacting other functionalities, though sync consumers remain unchanged.

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings | Greptile}

botberry · 2025-03-28T12:22:05Z

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Fix GraphQL IDE charset error that showed non-printing characters.

Here's the tweet text:

🆕 Release (next) is out! Thanks to @moritz89 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

codecov · 2025-03-28T12:26:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (de07ab6) to head (075d223).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3824   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files         499      499           
  Lines       32417    32417           
  Branches     1681     1681           
=======================================
  Hits        30877    30877           
  Misses       1275     1275           
  Partials      265      265

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codspeed-hq · 2025-03-28T12:33:33Z

CodSpeed Performance Report

Merging #3824 will not alter performance

_{Comparing moritz89:main (075d223) with main (0d9ffa5)}

Summary

✅ 21 untouched benchmarks

moritz89 · 2025-03-28T13:50:10Z

PR Summary

This PR updates the async GraphQL IDE in http_handler.py to explicitly set the content-type header to "text/html; charset=utf-8", addressing formatting errors seen in GraphiQL (#3821).
* In strawberry/channels/handlers/http_handler.py, render_graphql_ide() now returns "text/html; charset=utf-8" for async IDE responses.

* The change resolves hidden character issues in GraphiQL without impacting other functionalities, though sync consumers remain unchanged.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s) Edit PR Review Bot Settings | Greptile

Updated MR to handle sync consumer as well

greptile-apps

PR Summary

(updates since last review)

This PR fixes the GraphQL IDE charset issue in http_handler.py by explicitly setting the content-type header to "text/html; charset=utf-8", eliminating hidden characters in GraphiQL.

Modified /strawberry/channels/handlers/http_handler.py: render_graphql_ide now returns "text/html; charset=utf-8".
Applies change consistently for both async and sync GraphQLHTTPConsumer handlers.
Resolves the formatting error reported in issue Partial content-type results in GraphiQL formatting errors #3821 with minimal impact on existing functionality.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings | Greptile}

patrick91

thank you so much!

do you want to add a RELEASE.md file so we ship this? :D

RELEASE.md

* Fix GraphQL IDE charset error Why: - Hide non-printing characters This change addresses the need by: - Explicitly setting the content-type charset to utf-8 * Include sync http consumer * Add release file * Update RELEASE.md --------- Co-authored-by: Patrick Arminio <patrick.arminio@gmail.com>

Fix GraphQL IDE charset error

1f07408

Why: - Hide non-printing characters This change addresses the need by: - Explicitly setting the content-type charset to utf-8

sourcery-ai bot reviewed Mar 28, 2025

View reviewed changes

greptile-apps bot reviewed Mar 28, 2025

View reviewed changes

Include sync http consumer

f4fd7e4

greptile-apps bot reviewed Mar 28, 2025

View reviewed changes

patrick91 approved these changes Mar 28, 2025

View reviewed changes

Add release file

84ad713

botberry added bot:has-release-file bot:release-type-patch labels Mar 28, 2025

patrick91 reviewed Mar 28, 2025

View reviewed changes

RELEASE.md Outdated Show resolved Hide resolved

Update RELEASE.md

075d223

patrick91 enabled auto-merge (squash) March 28, 2025 16:39

patrick91 merged commit 31aec15 into strawberry-graphql:main Mar 28, 2025
95 of 97 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix GraphQL IDE charset error #3824

Fix GraphQL IDE charset error #3824

moritz89 commented Mar 28, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Mar 28, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

greptile-apps bot left a comment

botberry commented Mar 28, 2025 •

edited

Loading

codecov bot commented Mar 28, 2025 •

edited

Loading

codspeed-hq bot commented Mar 28, 2025 •

edited

Loading

moritz89 commented Mar 28, 2025

PR Summary

greptile-apps bot left a comment

patrick91 left a comment

Fix GraphQL IDE charset error #3824

Fix GraphQL IDE charset error #3824

Conversation

moritz89 commented Mar 28, 2025 • edited by sourcery-ai bot Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Summary by Sourcery

sourcery-ai bot commented Mar 28, 2025 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

botberry commented Mar 28, 2025 • edited Loading

codecov bot commented Mar 28, 2025 • edited Loading

Codecov Report

codspeed-hq bot commented Mar 28, 2025 • edited Loading

CodSpeed Performance Report

Merging #3824 will not alter performance

Summary

moritz89 commented Mar 28, 2025

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

patrick91 left a comment

Choose a reason for hiding this comment

moritz89 commented Mar 28, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Mar 28, 2025 •

edited

Loading

botberry commented Mar 28, 2025 •

edited

Loading

codecov bot commented Mar 28, 2025 •

edited

Loading

codspeed-hq bot commented Mar 28, 2025 •

edited

Loading