Python pydantic #1082
Draft
Python pydantic #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
python-pydantic
branch
from
3774f65
to
95c2400
Compare
|
I don't think the tests are complete enough to test the StoppedPool class, so a test success means nothing. |
mulkieran
force-pushed
the
python-pydantic
branch
3 times, most recently
from
b773aca
to
f24d6dd
Compare
Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
python-pydantic
branch
from
f24d6dd
to
86b545f
Compare
Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
python-pydantic
branch
from
86b545f
to
5531707
Compare
|
We will have to postpone requiring pydantic for a while longer. Also, in order to use it, we would have to recursively convert any dbus-python property to appropriate native Python types before passing the objects to the pydantic parser. In a sense, we should have written the recursive parser long ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.