-
Notifications
You must be signed in to change notification settings - Fork 4
Increase GitHub Action checkout version to v5 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase GitHub Action checkout version to v5 #123
Conversation
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
WalkthroughUpdated GitHub Actions workflows to use actions/checkout@v5 and set persist-credentials: false in checkout steps for main.yml and push.yml. No other workflow logic or steps were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/main.yml (1)
91-93: Second checkout step likewise updated — consistent and correctMirrors the earlier step. No issues spotted. If you ever need tags or full history for Makefile/package tasks, consider fetch-depth: 0 on checkout (not required by current workflow).
.github/workflows/push.yml (1)
36-40: Upgrade to actions/checkout@v5 with explicit persist-credentials: false — aligned with best practicesUse of path: into-dbus-python remains correct, and subsequent working-directory steps already point there. Disabling credential persistence is appropriate since this job only diffs locally and doesn’t push.
Optional hardening ideas (no change required):
- Pin actions/checkout to a specific commit SHA for supply-chain hardening.
- Add top-level permissions: contents: read to be explicit about least privilege.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/main.yml(2 hunks).github/workflows/push.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: monkeytype
🔇 Additional comments (1)
.github/workflows/main.yml (1)
49-51: All checkout steps updated to v5 with credentials not persisted — approved
Verification confirms:
- Every
actions/checkoutinvocation in.github/workflowsis at@v5withpersist-credentials: false- No steps run
git push|fetch|pullthat would need an authenticated token- No submodule checkouts that would require credentials
Safe to merge.
Related stratis-storage/project#807
Summary by CodeRabbit