Add options to base command to fix v3 functionality #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2022
## [2.2.3](v2.2.2...v2.2.3) (2022-04-24) ### Bug Fixes * **v3 options:** Add options to base command to fix as of v3 ([#7](#7)) ([131a38a](131a38a))
|
🎉 This PR is included in version 2.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This changeset restores 'sls online' functionality when using serverless v3.
Linked Issues to Close
Closes #6
Approach
As outlined in #6, serverless' deprecation of free form options caused this bug to surface. This plugin had been relying on the free form "fucntion" option when calling "sls online --function myfunc --stage mystage" (note the lack of subcommand 'start').
With the deprecation in v3, the base command began failing.
This changeset makes it so the base command 'sls online' and start subcommand 'sls online start' both define and expect a function parameter.
Learning
Learning about the deprecation was crucial... https://www.serverless.com/framework/docs/deprecations#handling-of-unrecognized-cli-options
Until I realized that, this was really confusing.
Assorted Notes/Considerations
N/A
Pull Request Creator Checklist
Pull Request Assignee Checklist