Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add base Italian translations #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mithenks
Copy link

@mithenks mithenks commented Jun 6, 2022

This PR add Italian translations.

@@ -26,7 +26,10 @@ const SeoChecker = ({ checks }) => {
return (
<Box paddingTop={4}>
<Typography variant="omega" fontWeight="semiBold">
SEO Summary
{formatMessage({
id: getTrad('SEOComponent.title.summary'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not creating translations for SEOComponent.title.summary in en and fr but a SEO Summary one instead.

Can you please remove the SEO Summary, add the SEOComponent.title.summary in both fr and en?

@@ -43,7 +43,10 @@ const BrowserPreview = ({ modifiedData, setIsVisible }) => {
>
<ModalHeader>
<Typography fontWeight="bold" textColor="neutral800" as="h2" id="title">
SEO Plugin
{formatMessage({
id: getTrad('plugin.name'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be Plugin.name?

@@ -75,5 +76,6 @@
"Improvements": "Improvements",
"Bad": "Bad",
"Social-preview.alert": "Complete you social component to see the preview",
"Information": "Information"
"Information": "Information",
"SEO Summary": "SEO Summary"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be replaced. See comment above :)

@Mcastres
Copy link
Collaborator

Thanks for your translation PR @mithenks 💪

@SalahAdDin
Copy link

@mithenks could you check this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants