Skip to content

Add graphQL landingPage configuration and updates Playground → Sandbox #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 15, 2025
Merged

Add graphQL landingPage configuration and updates Playground → Sandbox #2343

merged 11 commits into from
Jan 15, 2025

Conversation

innerdvations
Copy link
Collaborator

@innerdvations innerdvations commented Jan 9, 2025 •
edited
Loading

What does it do?

  • Adds the graphql landingPage config option
  • renames "playground" to sandbox/landing page. "landing page" is what Apollo calls whatever page is shown at the base url, and "graphql sandbox" is the particular landing page that it (and Strapi) uses by default.

Why is it needed?

"playground" is no longer the correct term in Apollo Server v4 (used in Strapi v5)

Related issue(s)/PR(s)

strapi/strapi#22285

NOTE: this should be published at the same time as next week's release (probably 5.7.1)

@innerdvations innerdvations requested a review from pwizla as a code owner January 9, 2025 12:14
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 9:54am

@innerdvations innerdvations changed the title enhancement: add landingPage config enhancement: add graphQL landingPage config Jan 9, 2025
@innerdvations
Copy link
Collaborator Author

@pwizla Could I leave you in charge of cleaning up or adding any wording or formatting?

DX will test the examples and make sure those are ok.

pwizla
pwizla reviewed Jan 9, 2025
View reviewed changes
pwizla
pwizla reviewed Jan 9, 2025
View reviewed changes
pwizla
pwizla reviewed Jan 9, 2025
View reviewed changes
pwizla
pwizla reviewed Jan 9, 2025
View reviewed changes
pwizla
pwizla reviewed Jan 9, 2025
View reviewed changes
pwizla
pwizla reviewed Jan 9, 2025
View reviewed changes
pwizla
pwizla reviewed Jan 9, 2025
View reviewed changes
pwizla
pwizla reviewed Jan 9, 2025
View reviewed changes
pwizla
pwizla approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thank you, Ben. I fixed a few things, incl. the broken anchors that were preventing the build.

@pwizla pwizla self-assigned this Jan 10, 2025
@pwizla pwizla added this to the 5.5.2 milestone Jan 10, 2025
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: updated content PRs updating existing documentation content labels Jan 10, 2025
@innerdvations innerdvations mentioned this pull request Jan 13, 2025
Merged
remidej
remidej reviewed Jan 15, 2025
View reviewed changes
pwizla and others added 2 commits January 15, 2025 10:47
@pwizla @remidej
Update docusaurus/docs/dev-docs/plugins/graphql.md
7e19443 
Co-authored-by: Rémi de Juvigny <8087692+remidej@users.noreply.github.com>
@pwizla @remidej
Update docusaurus/docs/dev-docs/plugins/graphql.md
a522c89 
Co-authored-by: Rémi de Juvigny <8087692+remidej@users.noreply.github.com>
@pwizla pwizla changed the title enhancement: add graphQL landingPage config Add graphQL landingPage configuration and updates Playground → Sandbox Jan 15, 2025
@pwizla pwizla added the temp - port to docs-next (Temporary label) The content of this PR should be ported to docs-next.strapi.io label Jan 15, 2025
@pwizla pwizla merged commit 8638fa7 into main Jan 15, 2025
3 checks passed
@pwizla pwizla deleted the enh/graphql-sandbox branch January 15, 2025 16:11
pwizla added a commit that referenced this pull request Jan 16, 2025
@pwizla
Port #2343
38fec9e
@pwizla pwizla removed the temp - port to docs-next (Temporary label) The content of this PR should be ported to docs-next.strapi.io label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remidej remidej remidej left review comments

@pwizla pwizla pwizla approved these changes

@derrickmehaffy derrickmehaffy derrickmehaffy approved these changes

@jhoward1994 jhoward1994 jhoward1994 approved these changes

@butcherZ butcherZ Awaiting requested review from butcherZ

@Bassel17 Bassel17 Awaiting requested review from Bassel17

Assignees

@pwizla pwizla

Labels
pr: updated content PRs updating existing documentation content source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Milestone
5.5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@innerdvations @pwizla @remidej @derrickmehaffy @jhoward1994