Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local-ic: Update to SDK v50 #737

Merged
merged 7 commits into from
Sep 7, 2023
Merged

local-ic: Update to SDK v50 #737

merged 7 commits into from
Sep 7, 2023

Conversation

Reecepbcups
Copy link
Member

Per Dan K's comment

Summary

  • Adds local-ic build CI
  • Updates local-ic to SDK v50 (uses a go quirk which replaces a null commit to parent)

@Reecepbcups Reecepbcups marked this pull request as ready for review September 6, 2023 03:08
@Reecepbcups Reecepbcups requested a review from a team as a code owner September 6, 2023 03:08
Reecepbcups added a commit to colin-axner/interchaintest that referenced this pull request Sep 6, 2023
Copy link
Contributor

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be wise to get these changes backported into the v7 branch. Specifically the workflow.

It's probably easier to do this with a separate PR rather than using mergify. But your call @Reecepbcups.

@Reecepbcups
Copy link
Member Author

Reecepbcups commented Sep 6, 2023

@boojamya I will do manually

Reecepbcups added a commit that referenced this pull request Sep 7, 2023
* ci: local-interchain builder

* patch gomod replaces with null commits for v7

* revert to go 1.19

Co-authored-by: Dan Kanefsky <56059752+boojamya@users.noreply.github.com>

---------

Co-authored-by: Dan Kanefsky <56059752+boojamya@users.noreply.github.com>
@Reecepbcups Reecepbcups merged commit c8f3d37 into main Sep 7, 2023
7 checks passed
@Reecepbcups Reecepbcups deleted the reece/localic-ci-and-gomod branch September 7, 2023 02:28
Reecepbcups added a commit that referenced this pull request Sep 13, 2023
* chore: bump ibc-go path to v8

* fix: go.mod in local-interchain

* go mod tidy

* fix: localic minor tweaks from #737

---------

Co-authored-by: Reece Williams <reecepbcups@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants