fix: cors and sse for logs #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frechg
commented
Oct 16, 2024
frechg
commented
- Updates local-interchain Docker to provide ssl certificates allowing testnet config json to be loaded remotely
- Fixes logs server CORS errors
- Fixes Server Sent Events formatting errors
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Reecepbcups
changed the title
Reecepbcups
reviewed
Oct 17, 2024
| @@ -79,7 +79,7 @@ func (ls *LogStream) StreamLogs(w http.ResponseWriter, r *http.Request) { | |||
| line, err := reader.ReadString('\n') | |||
| if err == nil { | |||
| // Send the log line to the client | |||
| fmt.Fprintf(w, "%s\n", line) | |||
| fmt.Fprintf(w, "data: %s\n\n", line) | |||
There was a problem hiding this comment.
assume this is for pretty parsing client side?
There was a problem hiding this comment.
Yeah, the data key and double new line at the end is proper server sent event format. You can get the event stream and manually handle it, but it won't work with the EventSource interface if it's not in that format. https://developer.mozilla.org/en-US/docs/Web/API/EventSource
Reecepbcups
approved these changes
Oct 17, 2024
Reecepbcups
merged commit 94f22e6
into
strangelove-ventures:reece/local-ic-stream-logs
11 of 13 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.