fix(local-ic): multiple ics, faster relayer #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Reecepbcups
changed the title
Reecepbcups
commented
Aug 25, 2024
Comment on lines
+157
to
+160
| { | ||
| "key": "app_state.feemarket.params.enabled", | ||
| "value": false | ||
| }, |
There was a problem hiding this comment.
breaks relayer without turning off
agouin
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Timewave has been using local-interchain extensively and has come across some issues. This PR resolves those.
✅ Issue 1 - Multiple ICS chains
When building multiple ICS chains, local-ic improperly only set the last consumer found, not all.
This is resolved as I forgot to iterate each consumer, as the parent for loop would not do that (just the providers). Leading to only the last consumer being setup.
✅ Issue 2 - Fast Chains
They want to run chains fast, and the relayer can not keep up. Added
MinLoopDurationfrom upstream go rly -> here with env override for faster or slower (default 50ms). No userspace config changes required