feat(local-ic): catch os.Interrupt / sigterm signals and cleanup #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Reecepbcups
changed the title
Reecepbcups
commented
Aug 7, 2024
joelsmith-2019
approved these changes
Aug 7, 2024
|
re-tested with enw changes (despite no logical differnces). confirmed working still as expected It's a used enough feature I do not think a test case for it makes sense to invest that time. So unless we have problems, manual is the best way
|
Reecepbcups
added a commit
that referenced
this pull request
Aug 9, 2024
Reecepbcups
added a commit
that referenced
this pull request
Aug 9, 2024
* refactor: move back to previous formats (#1206 for ref) * Cleanup using labels instead of name prefix * fix sidecar extra - prefix * fix: rust e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since local-ic was created, ctrl+c has been on the back burner for a year. It now properly cleans up a running instance.
Breaking Consideration
ict-namespaces had to be added to containers so we don't kill non ict based networks. This MAY be breaking for some users of ICT if they hardcode expect values as hostnames. To fix, they would have to addict-to the start of their container name.This verification actually broke one of my rust test here, but this is likely only due to internal verifications. I don't see why someone would do this outside of this repo.
Manual Testing
docker run -p 8080:80 -v "$PWD":/usr/local/apache2/htdocs/ httpd:2.4