generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 499
feat: Create a new HookEvent for Multiagent #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JackYPCOnline
merged 2 commits into
strands-agents:main
from
JackYPCOnline:change_origin_hooks
Sep 26, 2025
Merged
feat: Create a new HookEvent for Multiagent #925
JackYPCOnline
merged 2 commits into
strands-agents:main
from
JackYPCOnline:change_origin_hooks
Sep 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
reviewed
Sep 25, 2025
ca06723 to
8c6f24e
Compare
e80b3e1 to
0a9343d
Compare
0a9343d to
2c09912
Compare
mkmeral
previously approved these changes
Sep 26, 2025
2c09912 to
aed234f
Compare
aed234f to
01ac8b3
Compare
zastrowm
approved these changes
Sep 26, 2025
Unshure
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need a new hook event class that does not have
agentas parameter for Multiagent.So this PR creates a new hook event base class. The old single agent hook extend this hook base class, so it remains the same.
Is this meant to replace HookEvent?
We have to introduce a new base event that doesn't have an Agent property; we can't update the old event, because folks could be using it already.
If we were doing this from the get-go to support Multi-Agent, we'd most likely just be adding agent: Agent to each non-multi-agent hook instead of having it in the base class, but hooks didn't account for multi-agent
Related Issues
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.