Fix type annotations and parameter handling in Agent class #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Type Annotation Improvements: - Changed kwargs: Any to kwargs: Dict[str, Any] in _run_loop method - Changed dict[str, Any] to Dict[str, Any] in _execute_event_loop_cycle - Improved all Callable type annotations to Callable[..., Any] 2. Default Parameter Value Fix: - Changed callback_handler default from PrintingCallbackHandler() to None - This avoids the anti-pattern of using a mutable default parameter value 3. Parameter Mutation Protection: - Added .copy() to kwargs in both __call__ and stream_async methods - This prevents modifications to the kwargs dictionary from affecting the original
awsarron
requested changes
May 23, 2025
| @@ -340,7 +340,7 @@ def __call__(self, prompt: str, **kwargs: Any) -> AgentResult: | |||
|
|
|||
| try: | |||
| # Run the event loop and get the result | |||
| result = self._run_loop(prompt, kwargs) | |||
| result = self._run_loop(prompt, kwargs.copy()) | |||
There was a problem hiding this comment.
It can be useful to pass in a value and have the agent modify it during its execution which is achieved by not copying kwargs.
Could we move this change out of this PR for now, along with the kwargs copy on line 403?
This addresses PR feedback by: 1. Adding a sentinel object _DEFAULT_CALLBACK_HANDLER to distinguish between default and explicit None 2. Using the sentinel as the default parameter value for callback_handler 3. Creating a new PrintingCallbackHandler instance when the sentinel is used 4. Preserving the behavior where explicitly passing None uses null_callback_handler 5. Updating the docstring to reflect these changes
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues in the Agent class:
Type Annotation Improvements:
Default Parameter Value Fix:
Parameter Mutation Protection:
These changes improve the code's type safety, prevent potential bugs related to mutable default parameters, and ensure that input parameters are not unexpectedly modified during execution.