Skip to content

Conversation

@pgrayy
Copy link
Member

@pgrayy pgrayy commented Jul 12, 2025

Description

The Ollama model provider doesn't use the ollama client in its init and thus we don't need to mock it out for the init test fixture.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe): Minor clean up in tests.

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pgrayy pgrayy marked this pull request as ready for review July 12, 2025 22:55
@pgrayy pgrayy merged commit 61f9c59 into strands-agents:main Jul 12, 2025
22 checks passed
@pgrayy pgrayy deleted the ollama-tests branch July 14, 2025 13:18
dbschmigelski pushed a commit to Ketansuhaas/sdk-python that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants