Skip to content

refactor(mcp): address async warnings #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jer96
Copy link
Member

@jer96 jer96 commented Jul 11, 2025

Description

@pgrayy discovered that async warnings have emerged after merging #406 . This PR address those warnings.

Related Issues

Documentation PR

Type of Change

Address warnings

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Tested with sample script

import logging

from mcp import StdioServerParameters, stdio_client

from strands import Agent
from strands.models.openai import OpenAIModel
from strands.tools.mcp import MCPClient

logging.basicConfig(level=logging.DEBUG)


stdio_mcp_client = MCPClient(
    lambda: stdio_client(StdioServerParameters(command="uvx", args=["awslabs.aws-documentation-mcp-server@latest"]))
)

with stdio_mcp_client:
    tools = stdio_mcp_client.list_tools_sync()

    model = OpenAIModel(
        {
            "api_key": API_KEY,
        },
        model_id="gpt-4o",
    )
    agent = Agent(model=model, tools=tools, callback_handler=None)
    result = agent("what tools do you have")
    result = agent("get me details about lambda, dynamodb, sqs and aurora")
    print(result.message)

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jer96 jer96 temporarily deployed to auto-approve July 11, 2025 17:58 — with GitHub Actions Inactive
@jer96 jer96 requested a review from pgrayy July 11, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant