Skip to content

refactor: Remove _remove_dangling_messages from SlidingWindowConversationManager #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

Unshure
Copy link
Member

@Unshure Unshure commented Jul 11, 2025

Breaking Change!!

Description

Remove _remove_dangling_messages from SlidingWindowConversationManager.

Retain previous behavior

For users who want to keep the behavior that the sdk provided before this change, you can add the following logic after your agent call:

agent.(<Your input here>)
if len(agent.messages) > 0 and agent.messages[-1]["role"] == "assistant":
    if any("toolUse" in content for content in agent.messages[-1]["content"]):
        agent.messages.pop()

We believe this currently only happens if the event-loop is interrupted by client applications and thus believe that clients should handle this case outside of the loop.

In the future, we expect dangling tool_use messages to be a valid use-case where agents can resume from and thus we're removing this logic before we got 1.0

Related Issues

N/A

Documentation PR

N/A

Type of Change

Breaking change

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

zastrowm
zastrowm previously approved these changes Jul 11, 2025
Copy link
Member

@zastrowm zastrowm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a breaking change notice and how customers can do this themselves?

zastrowm
zastrowm previously approved these changes Jul 11, 2025
@Unshure
Copy link
Member Author

Unshure commented Jul 11, 2025

Can you add a breaking change notice and how customers can do this themselves?

Added to the description

@Unshure Unshure merged commit 10555be into strands-agents:main Jul 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants