Skip to content

models - bedrock - threading #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Conversation

pgrayy
Copy link
Member

@pgrayy pgrayy commented Jul 11, 2025

Description

While we wait for an async bedrock client, we will execute converse_stream in a separate thread so as to prevent hogging on the async event loop.

Related Issues

#83

Documentation PR

This is an internal only change.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare
  • Ran the integration tests
  • Ran the following test script:
import asyncio

from strands import Agent
from strands.models.bedrock import BedrockModel

prompt = "What is 2+2? Think through the steps."


async def func_a():
    agent = Agent(model=BedrockModel(), callback_handler=None)
    result = await agent.invoke_async(prompt)
    print(f"FUNC_A: {result.message}")


async def func_b():
    agent = Agent(model=BedrockModel(), callback_handler=None)
    result = await agent.invoke_async(prompt)
    print(f"FUNC_B: {result.message}")


async def func_c():
    agent = Agent(model=BedrockModel(), callback_handler=None)
    result = await agent.invoke_async(prompt)
    print(f"FUNC_C: {result.message}")


async def func_d():
    agent = Agent(model=BedrockModel(), callback_handler=None)
    result = await agent.invoke_async(prompt)
    print(f"FUNC_D: {result.message}")


async def main():
    await asyncio.gather(func_a(), func_b(), func_c(), func_d())


asyncio.run(main())

Without running converse_stream in a thread, all functions execute sequentially for a total average time of 10s. With threading, the functions execute concurrently and complete in an average of 4s.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pgrayy pgrayy marked this pull request as ready for review July 11, 2025 05:19
@pgrayy pgrayy merged commit a0f7c24 into strands-agents:main Jul 11, 2025
19 of 22 checks passed
@pgrayy pgrayy mentioned this pull request Jul 11, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants