Refactor event loop to use Agent object rather than individual parameters #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parameters Update the event_loop_cycle function to accept the agent directly instead of the separate parameters that were coming directly from the agent. This simplifies + clarifies exactly what the event loop is doing with the agent. Long-term this sets us up for more easily access other agent capabilities like hooks. There is a downside here of tighter coupling between the agent & the event_loop - an alternative implementation of this would be to abstract the object being passed - maybe something like `EventLoopContext`. I originally started implementing this approach before revisiting it as it seemed like an unnecessary abstraction.
pgrayy
reviewed
Jul 5, 2025
ToolHandler's requirements have been reduced enough where it probably doesn't warrant a separate class, especially given that event into executor a partial function is passed in to conform to the requirement.
pgrayy
approved these changes
Jul 7, 2025
jsamuel1
pushed a commit
to jsamuel1/sdk-python
that referenced
this pull request
Jul 9, 2025
…ters (strands-agents#359) Update the event_loop_cycle function to accept the agent directly instead of the separate parameters that were coming directly from the agent. This simplifies + clarifies exactly what the event loop is doing with the agent. Long-term this sets us up for more easily access other agent capabilities like hooks. There is a downside here of tighter coupling between the agent & the event_loop - an alternative implementation of this would be to abstract the object being passed - maybe something like `EventLoopContext`. I originally started implementing this approach before revisiting it as it seemed like an unnecessary abstraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the event_loop_cycle function to accept the agent directly instead of the separate parameters that were coming directly from the agent. This simplifies + clarifies exactly what the event loop is doing with the agent. Long-term this sets us up for more easily access other agent capabilities like hooks.
There is a downside here of tighter coupling between the agent & the event_loop - an alternative implementation of this would be to abstract the object being passed - maybe something like
EventLoopContext. I originally started implementing this approach before revisiting it as it seemed like an unnecessary abstraction.I am open to feedback regarding the tighter coupling/however.
Notes
With this the ToolHandler abstraction is un-necessary since we're not passing that in and we're binding the actual tool call to pass into the tool-executor anyways. After some discussion on the PR, I moved the
ToolHandler.rundirectly into the event loop, as this seemed the best place and sets us up for future changes w.r.t. hooks.Related Issues
N/A
Documentation PR
N/A
Type of Change
Other (please describe): Refactor
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.