Skip to content

tools - parallel execution - sleep #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Conversation

pgrayy
Copy link
Member

@pgrayy pgrayy commented Jul 4, 2025

Description

Tool invocation is being reworked to support streaming of events that the agent can pass to the callback handler on behalf of the user. As part of this reworking, we updated the parallel tool execution logic to utilize a queue for sharing events with the main thread. There is some busy waiting however in the main thread that is slowing down overall tool execution. Adding a sleep to combat this. Will explore other options as well. This is just an immediate fix.

From simple experiments with the use_aws tool, invocation dropped from an average of 30 seconds to 5 seconds.

Related Issues

#356

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pgrayy pgrayy temporarily deployed to auto-approve July 4, 2025 16:59 — with GitHub Actions Inactive
@pgrayy pgrayy requested a review from awsarron July 4, 2025 16:59
@pgrayy pgrayy marked this pull request as ready for review July 4, 2025 17:01
@pgrayy pgrayy merged commit dff627d into strands-agents:main Jul 4, 2025
18 of 32 checks passed
pgrayy added a commit to pgrayy/sdk-python that referenced this pull request Jul 4, 2025
pgrayy added a commit that referenced this pull request Jul 4, 2025
jsamuel1 pushed a commit to jsamuel1/sdk-python that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants