Add cohere client #236
Merged
Add cohere client #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkozakov
reviewed
Jun 17, 2025
billytrend-cohere
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Unshure
requested changes
Jun 23, 2025
There was a problem hiding this comment.
Thank you for the contribution here! This looks like a light wrapper around the existing OpenAI implementation, which is not an implementation pattern we like to follow. Instead, I would be happy to accept a ModelProvider that uses Cohere's own sdk: https://docs.cohere.com/reference/about#python
Let me know if this is an update you are interested in contributing!
|
Added some docs here strands-agents/docs#108 |
|
We are planning on having a mostly docs-based implementation, so lets remove this implementation, but keep the newly added integration test. |
Unshure
force-pushed
the
billy/cohere-compat
branch
from
88e35bc to
18cd037
Compare
|
I accidentally committed a change to your pr, so I had to undo that, sorry about that. |
Unshure
requested changes
Jun 27, 2025
billytrend-cohere
requested a deployment
to
manual-approval
GitHub Actions
Waiting
billytrend-cohere
requested a deployment
to
manual-approval
GitHub Actions
Waiting
billytrend-cohere
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Unshure
approved these changes
Jul 8, 2025
malte-aws
pushed a commit
to malte-aws/sdk-python
that referenced
this pull request
Jul 10, 2025
* Add CohereModel * Format * Update pyproject.toml * Update src/strands/models/cohere.py * Revert cusom cli, keep only compat layer * Format and fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cohere client based on openai compatiblity layer