chore: moved truncation logic to conversation manager and added should_truncate_results#192
Merged
poshinchen merged 1 commit intostrands-agents:mainfrom Jun 11, 2025
Conversation
b02c6ac to
c5ab63d
Compare
…d_truncate_results
c5ab63d to
d31ab39
Compare
6 tasks
Unshure
approved these changes
Jun 10, 2025
6 tasks
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Jul 2, 2025
…d_truncate_results (strands-agents#192)
jsamuel1
pushed a commit
to jsamuel1/sdk-python
that referenced
this pull request
Jul 9, 2025
…d_truncate_results (strands-agents#192)
dbschmigelski
pushed a commit
to Ketansuhaas/sdk-python
that referenced
this pull request
Jul 24, 2025
…d_truncate_results (strands-agents#192)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
should_truncate_resultsflag (Default: True).The behavior of the reduce_context will be:
ContextWindowOverflowExceptionis first thrown, ifshould_truncate_resultsis not explicitly set to False, the tool result will get truncated first and execute the event loop again.ContextWindowOverflowExceptionis thrown again after the truncation, the message history starts to get reducedContextWindowOverflowExceptionif nothing can be reduced by conversation managerRelated Issues
#152
#167
Documentation PR
Will update the documentation as follow up.
Type of Change
Testing
[How have you tested the change?]
hatch fmt --linterhatch fmt --formatterhatch test --allChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.