Skip to content

Conversation

@mehtarac
Copy link
Member

Description

This PR adds support for throttlingException in bedrock model provider. After these changes, any user's request that encounters ThrottlingException or throttlingException will be raised as a ModelThrottledException which the sdk has a retry mechanism for.

Considerations:

  • I considered two approaches for this fix.
  1. Handle both exceptions with to.lower()
  2. Use an or operator to check for both.

I decided to go with the second approach mainly due to the bedrock documentation. The API Reference documents both exceptions and so it made sense to treat them individually (although the end user experience doesn't change).

Related Issues

#905

Documentation PR

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mehtarac mehtarac requested a review from a team October 27, 2025 14:36
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mehtarac mehtarac merged commit 73865d3 into strands-agents:main Oct 27, 2025
14 checks passed
error_message = str(e)

if e.response["Error"]["Code"] == "ThrottlingException":
if (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cleaner to just .lower() both so we don't need the or

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants