generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 499
mcp elicitation #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
mcp elicitation #1094
+92
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
98c5be7 to
c4e2520
Compare
JackYPCOnline
approved these changes
Oct 27, 2025
afarntrog
reviewed
Oct 27, 2025
afarntrog
approved these changes
Oct 27, 2025
6 tasks
dbschmigelski
approved these changes
Oct 28, 2025
dbschmigelski
pushed a commit
to schnetler/sdk-python
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow customers to pass an elicitation callback to the
MCPClient(docs).Note, I did prototype running elicitation through the Strands interrupt workflow but decided to hold off for the following reasons:
MCPClientis torn down, the elicitation request is lost.AgentResultand pass in a separateinterruptResponses payload. Everything can just be handled in the callback.elicitation_callbackisNoneand if so, we provide our own callback that translates the elicitation requests intoInterruptException's.Usage
Related Issues
#204
Documentation PR
strands-agents/docs#300
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run preparehatch test tests_integ/mcp/test_mcp_elicitation.py: Wrote new integ tests.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.