Fix AttributeError: 'dict' object has no attribute 'merge' in BedrockModel #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug in the Bedrock model initialization that occurs when
boto_client_configis passed as a dictionary from JSON configuration parsing.Problem
AttributeError: 'dict' object has no attribute 'merge'BedrockModel.__init__method expectsboto_client_configto be aBotocoreConfigobject, but configuration parsing from JSON creates a plain dictionary.merge()on the dictionary, which doesn't have this methodSolution
instance()function to detect whenboto_client_configis a dictionaryBotocoreConfigobject before passing it toBedrockModelBotocoreConfigfrombotocore.configChanges
src/strands_agents_builder/models/bedrock.pyBotocoreConfigBotocoreConfigconversionTesting
This fix addresses the root cause by handling the type conversion at the appropriate layer (where configuration is processed before model instantiation) rather than adding workarounds in the core model implementation.