Refactor IdentityFile APIs
#518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
- Coverage 50.94% 50.57% -0.38%
==========================================
Files 42 42
Lines 4075 4117 +42
==========================================
+ Hits 2076 2082 +6
- Misses 1999 2035 +36 ☔ View full report in Codecov by Sentry. |
str4d
force-pushed
the
380-expose-ife-methods
branch
from
968dce3 to
4deff61
Compare
We now merge plugin recipients together, so we only run each plugin once during encryption.
This removes the need for explicit `callbacks` arguments in methods that may act on plugin identities, and instead enables the caller to choose whether or not to provide callbacks independently of plugin support being compiled in. Enabling plugin support without providing callbacks now has well-defined fallback behaviour via the default `NoCallbacks` struct.
This is doable now that `IdentityFile` stores callbacks, and is more useful to crate users than `IdentityFileEntry`. The one place we were relying on the latter was in `rage-keygen` to distinguish plugin identities (which cannot be re-encoded as recipients); we now move that functionality into the `age` crate.
str4d
force-pushed
the
380-expose-ife-methods
branch
from
4deff61 to
5e57ef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is the way, this was originally intended to expose methods on
IdentityFileEntry, and instead turned into a complete refactor that madeIdentityFileEntrysuperfluous (and now removed).Closes #380.