Repository navigation
Conversation
…pplies After "nothing in data set A was applied: no object is bound to a variable it has a value for" showed in the status bar, choosing a data set that did apply, or stepping to one, left that message in place. `run_now` set the status from a command's `warning` and cleared it only for `file.new`, and the Variables panel test cleared the status by hand before its last check. `dataset.select`, `dataset.next` and `dataset.prev` now clear the status bar when they succeed, and the warning shows when no object is bound to a variable the new data set has a value for. The test no longer clears the status by hand and checks all three commands.
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This follows up #3048. Import Data Sets… with a CSV that holds data sets A and B defines its variables without binding them. Choose data set A in the Variables panel, and the status bar shows "nothing in data set A was applied: no object is bound to a variable it has a value for". Then bind the variable to an object and choose data set B, or step to it with the panel's arrows. On
maindata set B applies and the message about A stays.run_now(crates/ui-egui/src/lib.rs) sets the status from a command'swarningand clears it only forfile.new, and the panel's test cleared the status by hand before its last check.dataset.select,dataset.nextanddataset.prevnow clear the status bar when they succeed, before the app shows the reply'swarning. A data set with a value for a bound variable leaves the status bar empty, and one without shows the message as before. The replies are unchanged.How it was tested
a_data_set_with_nothing_bound_shows_a_status_message(crates/ui-egui/src/panels/variables.rs) no longer clears the status by hand. After the variable is bound, it checks thatdataset.select,dataset.nextanddataset.preveach leave the status bar empty when the message showed before.With any one of the three commands left out of the new check in
run_now, the test fails on that command.Targeted checks:
cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings,cargo test -p vectorcraft-ui-egui --lib panels::variables(11 passed),cargo fmt --all -- --check,cargo xtask brands,cargo xtask layersandcargo xtask assets.On Windows 11 (x86-64) with rustc 1.99.0, on top of
mainatbc1ae08:CRAFT_FONTS_DIR=<craft-fonts checkout> cargo xtask cipasses its 10 steps: 8,570 tests passed, 0 failed, 13 ignored.git merge-treereports no conflicts withmainatbc1ae08.Checklist
cargo xtask cipasses (fmt, clippy, tests, assets, brands, layers, wasm).unwrap(),expect(),panic!,unreachable!,todo!orunimplemented!outside tests, and no unchecked indexing on data from files, parameters ormessages. Errors are returned as
Resultand shown to the user(why and how).
ASSETS.md.Summary by CodeRabbit