[lehni]

What and why

apps/vectorcraft/tests/automation_args.rs starts the vectorcraft binary with invalid root arguments and expects it to exit within 5 seconds. On a loaded machine (the workspace's other tests running meanwhile), starting the binary alone took longer, so three tests failed as "desktop started or did not exit promptly": missing_empty_or_option_operands_fail_before_startup, control_without_a_valid_port_fails_before_startup and duplicate_roots_fail_for_both_spellings.

The limit is now 30 seconds, with a comment saying why: still enough to catch a desktop that started instead of exiting, which is what the test is for.

How it was tested

• cargo test -p vectorcraft --test automation_args passes with the change.
• Before it, the three tests failed in a full cargo xtask ci run at a load average above 20, and passed on their own.

Checklist

• cargo xtask ci passes (fmt, clippy, tests, assets, brands, layers, wasm). Not run on this branch: only automation_args was.
• No panics in shipped code (test-only change).
• Clean-room: nothing copied from Adobe products or GPL/AGPL code.
• Every new asset has a row in ASSETS.md (no assets).

Summary by CodeRabbit

• Tests
  • Increased the timeout for an integration test from 5 seconds to 30 seconds, while preserving its existing failure checks and polling behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: storytold/vectorcraft/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 109efff2-8c97-4b50-9085-56acc97b8ffa

📥 Commits

Reviewing files that changed from the base of the PR and between bc1ae08 and e3f45c5.

📒 Files selected for processing: 1

• apps/vectorcraft/tests/automation_args.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The rejects_with_env integration test now allows 30 seconds for the binary to exit instead of 5 seconds. Its failure assertions and polling behavior remain unchanged.

Changes: Automation argument test

Layer / File(s)	Summary
Binary exit timeout apps/vectorcraft/tests/automation_args.rs	The test timeout increased from 5 seconds to 30 seconds. Comments document the startup allowance and prompt-exit check.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: piero-83

Merge Risk: ⚪ Minimal · up to e3f45

No actionable merge-blocking risk remains; the timeout change preserves the test's failure checks while accommodating slower environments.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely identifies the main change: increasing the root-argument test exit timeout from 5 seconds to 30 seconds.
Description check		The description includes the required What and why, How it was tested, and Checklist sections. It explains the failure cause, identifies affected tests, and reports the targeted test result. It also c…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes the required What and why, How it was tested, and Checklist sections. It explains the failure cause, identifies affected tests, and reports the targeted test result. It also clearly states that the full CI command was not run.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}