Repository navigation
Conversation
Store Symbol.dynamic (default static), expose it on symbol.new / list / duplicate, and add Static/Dynamic Type to Symbol Options with pt-br. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Thanks @Messhias. I'm holding this one for an owner decision. The public docs list Static Symbol and Dynamic Symbol in Symbol Options, but they don't say which one new symbols get by default. With this PR the Dynamic choice is stored but doesn't change anything yet, since per-instance overrides aren't there. The owner needs to decide whether to ship the option before overrides exist, and which default to use. |
This was referenced Oct 17, 2026
Contributor
Author
|
Closing for now: held pending an owner decision on Static/Dynamic default and whether to ship the option before per-instance overrides exist. Happy to reopen once that is settled; the branch had gone stale against main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Symbol.dynamic(serde default false) withSymbol::newfor static definitions; existing files stay static.symbol.new {dynamic?},symbol.listandsymbol.duplicatereport/keep the flag; Symbol Options offers Static / Dynamic Symbol (overrides and Global Edit still ahead).Test plan
cargo test -p vectorcraft-engine --lib tests_brushsym::symbol_new_dynamic_flag(passed)cargo clippy -p vectorcraft-doc -p vectorcraft-engine --lib -- -D warningscargo check -p vectorcraft-ui-egui