Skip to content

G11: dynamic symbol flag in Symbol Options - #1942

Closed
Messhias wants to merge 1 commit into
storytold:mainfrom
Messhias:feat/g11-dynamic-symbol-flag
Closed

Messhias wants to merge 1 commit into
storytold:mainfrom
Messhias:feat/g11-dynamic-symbol-flag

Conversation

@Messhias

@Messhias Messhias commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Symbol.dynamic (serde default false) with Symbol::new for static definitions; existing files stay static.
  • symbol.new {dynamic?}, symbol.list and symbol.duplicate report/keep the flag; Symbol Options offers Static / Dynamic Symbol (overrides and Global Edit still ahead).
  • PT-BR for the new Type labels; gaps/ui-parity note the flag is stored.

Test plan

  • cargo test -p vectorcraft-engine --lib tests_brushsym::symbol_new_dynamic_flag (passed)
  • cargo clippy -p vectorcraft-doc -p vectorcraft-engine --lib -- -D warnings
  • cargo check -p vectorcraft-ui-egui

Store Symbol.dynamic (default static), expose it on symbol.new / list /
duplicate, and add Static/Dynamic Type to Symbol Options with pt-br.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bflatastic

Copy link
Copy Markdown
Member

Thanks @Messhias. I'm holding this one for an owner decision.

The public docs list Static Symbol and Dynamic Symbol in Symbol Options, but they don't say which one new symbols get by default. With this PR the Dynamic choice is stored but doesn't change anything yet, since per-instance overrides aren't there. The owner needs to decide whether to ship the option before overrides exist, and which default to use.

@Messhias

Copy link
Copy Markdown
Contributor Author

Closing for now: held pending an owner decision on Static/Dynamic default and whether to ship the option before per-instance overrides exist. Happy to reopen once that is settled; the branch had gone stale against main.

@Messhias Messhias closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants