Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

feat: support cjs and esm #6

Merged
merged 1 commit into from
Nov 22, 2021
Merged

feat: support cjs and esm #6

merged 1 commit into from
Nov 22, 2021

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 22, 2021

should close #2

tsconfig.esm.json Outdated Show resolved Hide resolved
@ghengeveld
Copy link
Member

Nice. Did you verify whether it works with cjs as well? I'm not even sure how to force Storybook into using cjs.

@yannbf
Copy link
Member Author

yannbf commented Nov 22, 2021

Nice. Did you verify whether it works with cjs as well? I'm not even sure how to force Storybook into using cjs.

Yes, the scenario is not for Storybook but for running tests with @storybook/testing-react with stories that import @storybook/testing-library. Tested it in Mealdrop 👌

@ghengeveld ghengeveld merged commit 4028bcc into main Nov 22, 2021
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

🚀 PR was released in v0.0.9 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Built files are es6 modules, but the project is not marked as type: module
2 participants