Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added meta IE=edge #715

Merged
merged 4 commits into from
Apr 12, 2017
Merged

Added meta IE=edge #715

merged 4 commits into from
Apr 12, 2017

Conversation

nutgaard
Copy link
Contributor

@nutgaard nutgaard commented Mar 7, 2017

IE is sometimes configured to fall back to IE7-emulation on internal sites.

This forces IE to use its latest version on this site.

@ndelangen
Copy link
Member

@nutgaard would you be OK if this #723 was added (see issue here: #650). This would allow you to add X-UA-Compatibility response header, the see: https://msdn.microsoft.com/en-us/library/ff955275(v=vs.85).aspx

@nutgaard
Copy link
Contributor Author

@ndelangen I'm not that familiar with webpackDevMiddleware, so I'm not sure.
If #723 also affects the index.html when running build-storybook (e.g generating the static site) then I see no problems with that solution.

@ndelangen
Copy link
Member

I'll give that a try myself. If it doesn't work, I'll merge this. Thank you!

@ndelangen ndelangen self-assigned this Mar 28, 2017
@nutgaard
Copy link
Contributor Author

Found an alternative way of solving this, if the current solution seems a bit specific.

Currently storybook support adding elements to <head> in the iframe by creating a head.html file inside the .storybook folder (like the good people at airbnb have done). The contents are then merged into iframe.html.js.

I've just verified that this works as expected when running build-storybook.

So another option to this PR is to expose a similar head-file that can be injected into index.html.js giving us a bit more flexibility further down the line.

@ndelangen
Copy link
Member

Thank you @nutgaard !,

I'll just merge this, but may add a issue later that we should move this behaviour into a header, and the consumer should set such header using server-middleware.

@ndelangen ndelangen closed this Apr 12, 2017
@ndelangen ndelangen reopened this Apr 12, 2017
@ndelangen ndelangen merged commit 8d0d9aa into storybookjs:master Apr 12, 2017
@shilman shilman added the misc label May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nutgaard @ndelangen @shilman