Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to have multiple sections in the notes panel #6861

Merged
merged 3 commits into from
Jun 17, 2019
Merged

add ability to have multiple sections in the notes panel #6861

merged 3 commits into from
Jun 17, 2019

Conversation

hipstersmoothie
Copy link
Contributor

What I did

A user can now specify multiple notes with addon-notes

Screen Shot 2019-05-22 at 5 33 49 PM
Screen Shot 2019-05-22 at 5 26 52 PM
Screen Shot 2019-05-22 at 5 30 50 PM

How to test

  • Is this testable with Jest or Chromatic screenshots? yes
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? yes

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented May 23, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-more-notes.storybook.now.sh

@shilman shilman added this to the 5.2.0 milestone May 23, 2019
@ndelangen ndelangen self-assigned this Jun 7, 2019
@hipstersmoothie
Copy link
Contributor Author

@ndelangen anything else I need to do for this one? just resolved the merge conflict

@ndelangen ndelangen merged commit 5eb6af0 into next Jun 17, 2019
@ndelangen ndelangen deleted the more-notes branch June 17, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

Assignees

@ndelangen ndelangen

Labels
addon: notes feature request
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hipstersmoothie @ndelangen @shilman