Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel-postmessage: handle events from the same window #3519

Merged
merged 3 commits into from
May 1, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #1407 was intended to add an ability to use channel as an event bus working regardless of whether events comes to the same or to another (preview vs manager) window. But right now it works only with channel-websocket. This PR adds this ability to channel-postmessage as well

@codecov
Copy link

codecov bot commented May 1, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@df21fed). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3519   +/-   ##
========================================
  Coverage          ?   92.5%           
========================================
  Files             ?       6           
  Lines             ?      40           
  Branches          ?       2           
========================================
  Hits              ?      37           
  Misses            ?       2           
  Partials          ?       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df21fed...e6ac151. Read the comment docs.

@Hypnosphi Hypnosphi changed the title Channel-postmessage: send message to both windows Channel-postmessage: handle events from the same window May 1, 2018
@Hypnosphi Hypnosphi merged commit 1bee981 into master May 1, 2018
@Hypnosphi Hypnosphi deleted the postmessage-same-sender branch May 1, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants