Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress verbose build output #3487

Merged
merged 3 commits into from
Apr 25, 2018
Merged

Suppress verbose build output #3487

merged 3 commits into from
Apr 25, 2018

Conversation

bmson
Copy link
Contributor

@bmson bmson commented Apr 25, 2018 •
edited
Loading

Issue: #1872

What I did

This is bit of a stab in the dark to address the output noice in Storybook.
Added --quiet to the CLI command list, so we can conditionally load the webpack.ProgressPlugin.

How to test

yarn test --cli

@bmson
Copy link
Contributor Author

bmson commented Apr 25, 2018 •
edited
Loading

The "CircleCI" errors seem unrelated to this PR »Bad credentials
And I'm unable to check what failed on "TeamCity"

@Hypnosphi Hypnosphi changed the base branch from release/3.4 to master April 25, 2018 16:31
@Hypnosphi Hypnosphi added feature request configuration babel / webpack patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 25, 2018
@Hypnosphi
Copy link
Member

I've changed the PR base to master because we need to apply this change to mithril app as well. But it’s probably easier to open a new one than to resolve the conflicts

Please also document this option
https://github.com/storybooks/storybook/blob/master/docs/src/pages/configurations/cli-options/index.md

@codecov
Copy link

codecov bot commented Apr 25, 2018 •
edited
Loading

Codecov Report

Merging #3487 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3487      +/-   ##
==========================================
+ Coverage   37.42%   37.42%   +<.01%     
==========================================
  Files         455      455              
  Lines       10296    10295       -1     
  Branches      911      912       +1     
==========================================
  Hits         3853     3853              
+ Misses       5915     5910       -5     
- Partials      528      532       +4
Impacted Files Coverage Δ
app/polymer/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/react/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/vue/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/angular/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
lib/core/src/server/middleware.js 0% <0%> (ø) ⬆️
lib/core/src/server/build-dev.js 20.15% <50%> (+0.15%) ⬆️
addons/info/src/components/types/OneOf.js 61.11% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/routed_link.js 22.72% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
addons/info/src/components/types/PrettyPropType.js 85.71% <0%> (ø) ⬆️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b818f14...c1f3337. Read the comment docs.

@bmson bmson requested a review from Hypnosphi as a code owner April 25, 2018 17:29
@Hypnosphi
Copy link
Member

Please update config for app/mithril

@Hypnosphi Hypnosphi merged commit 18f6521 into storybookjs:master Apr 25, 2018
Hypnosphi added a commit that referenced this pull request Apr 25, 2018
@Hypnosphi
Integrate changes from #3487
9a919ff
@bmson bmson deleted the baldvin/verbose branch April 25, 2018 23:52
@ndelangen
Copy link
Member

Awesome work, thank you @bmson ! 👏

@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 27, 2018
Hypnosphi added a commit that referenced this pull request Apr 27, 2018
@Hypnosphi
Merge pull request #3487 from bmson/baldvin/verbose
555600f 
Suppress verbose build output
# Conflicts:
#	app/mithril/src/server/config/webpack.config.js
@Hypnosphi Hypnosphi mentioned this pull request Apr 27, 2018
Closed
@benniemosher
Copy link

Was this only applied to the start-storybook command? The docs don't have the --quiet option for build-storybook and the CLI is not accepting it. How hard would it be to get it done there too?

@ndelangen
Copy link
Member

It should work for both in V5 I think! Can you help us test?

@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hypnosphi Hypnosphi Hypnosphi approved these changes

@alterx alterx Awaiting requested review from alterx alterx is a code owner

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@kazupon kazupon Awaiting requested review from kazupon kazupon is a code owner

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@naipath naipath Awaiting requested review from naipath

@ndelangen ndelangen Awaiting requested review from ndelangen ndelangen is a code owner

@shilman shilman Awaiting requested review from shilman shilman is a code owner

@thomasbertet thomasbertet Awaiting requested review from thomasbertet thomasbertet is a code owner

@tmeasday tmeasday Awaiting requested review from tmeasday tmeasday is a code owner

Assignees
No one assigned
Labels
configuration babel / webpack feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmson @Hypnosphi @ndelangen @benniemosher