Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade image-size to 2.0 #30661

Closed
wants to merge 1 commit into from

Conversation

netroy
Copy link

@netroy netroy commented Feb 25, 2025

What I did

This PR upgrades image-size to 2.0.0, and removed the dependency on sharp for avif files.

Related PR storybookjs/vite-plugin-storybook-nextjs#32

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR upgrades the image-size package to version 2.0.0 and removes the sharp dependency, simplifying AVIF image handling in the Next.js framework integration.

  • Upgraded image-size to 2.0.0 in code/frameworks/nextjs/package.json for native AVIF support
  • Removed sharp from optionalDependencies as it's no longer needed
  • Simplified code/frameworks/nextjs/src/next-image-loader-stub.ts by removing special AVIF handling code
  • Updated import from imageSizeOf to imageSize to match new API

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@valentinpalkovic valentinpalkovic self-assigned this Feb 25, 2025
@valentinpalkovic valentinpalkovic added nextjs maintenance User-facing maintenance tasks ci:normal labels Feb 25, 2025
@netroy netroy marked this pull request as draft February 25, 2025 14:57
@netroy
Copy link
Author

netroy commented Feb 25, 2025

Marking this as draft until storybookjs/vite-plugin-storybook-nextjs#32 is merged. After that we can remove the 1.1.1 of image-size that's being pulled in a transitive dependency.

@valentinpalkovic valentinpalkovic marked this pull request as ready for review March 3, 2025 19:50
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Mar 3, 2025

Superseded by #30741. I had to update the yarn.lock file and I wasn't allowed to push to your PR. Otherwise, great work. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks nextjs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants