Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Maintenance #29526

Draft
wants to merge 11 commits into
base: next
Choose a base branch
from
Draft

Build: Maintenance #29526

wants to merge 11 commits into from

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 4, 2024

What I did

  • upgrade to latest version of yarn
  • dedupe dependencies
  • sync @storybook/icons version
  • upgrade prettier
  • regen lockfile in code

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.2 MB 78.2 MB 0 B 1.11 0%
initSize 143 MB 144 MB 813 kB 6.43 0.6%
diffSize 65.1 MB 65.9 MB 813 kB 131.69 1.2%
buildSize 6.88 MB 6.98 MB 106 kB 203.79 1.5%
buildSbAddonsSize 1.51 MB 1.5 MB -8.16 kB -Infinity -0.5%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.9 MB 1.91 MB 6.83 kB 18.48 0.4%
buildSbPreviewSize 271 kB 271 kB 491 B Infinity 0.2%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.88 MB 3.88 MB -842 B -0.74 0%
buildPreviewSize 3 MB 3.1 MB 107 kB 848.88 3.4%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 23.1s 7.5s -15s -643ms -0.91 -208%
generateTime 19.6s 21.9s 2.3s -0.2 10.7%
initTime 14.2s 16s 1.7s 0.06 11.1%
buildTime 8.8s 8.4s -428ms -0.71 -5.1%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.3s 6.5s 1.2s 0.54 19.3%
devManagerResponsive 3.2s 4.2s 943ms 0.61 22.3%
devManagerHeaderVisible 536ms 729ms 193ms 1.22 26.5%
devManagerIndexVisible 568ms 832ms 264ms 1.67 🔺31.7%
devStoryVisibleUncached 960ms 1.3s 439ms 0.97 31.4%
devStoryVisible 567ms 829ms 262ms 1.67 🔺31.6%
devAutodocsVisible 464ms 572ms 108ms 0.2 18.9%
devMDXVisible 470ms 654ms 184ms 1.53 🔺28.1%
buildManagerHeaderVisible 490ms 575ms 85ms -0.18 14.8%
buildManagerIndexVisible 503ms 600ms 97ms -0.08 16.2%
buildStoryVisible 492ms 574ms 82ms -0.19 14.3%
buildAutodocsVisible 414ms 497ms 83ms 0.25 16.7%
buildMDXVisible 437ms 633ms 196ms 1.86 🔺31%

@ndelangen ndelangen self-assigned this Nov 4, 2024
@ndelangen ndelangen added maintenance User-facing maintenance tasks ci:normal labels Nov 4, 2024
Copy link

nx-cloud bot commented Nov 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ce23889. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant