Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Remove duplicate comments #29469

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

DoHi0512
Copy link
Contributor

@DoHi0512 DoHi0512 commented Oct 29, 2024

What I did

Remove duplicate comments

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.2 MB 78.2 MB 0 B 1.11 0%
initSize 143 MB 143 MB 0 B 1.12 0%
diffSize 65.1 MB 65.1 MB 0 B 1.16 0%
buildSize 6.88 MB 6.88 MB 0 B 1.38 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.9 MB 1.9 MB 0 B 1.37 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.88 MB 3.88 MB 0 B 1.37 0%
buildPreviewSize 3 MB 3 MB 0 B 1.36 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 23.1s 7.4s -15s -721ms -0.92 -211.3%
generateTime 19.6s 21.6s 2s -0.29 9.3%
initTime 14.2s 15.2s 980ms -0.33 6.4%
buildTime 8.8s 8.8s 23ms -0.26 0.3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.3s 5.2s -111ms -1.03 -2.1%
devManagerResponsive 3.2s 3.3s 78ms -0.96 2.3%
devManagerHeaderVisible 536ms 567ms 31ms -0.49 5.5%
devManagerIndexVisible 568ms 665ms 97ms -0.11 14.6%
devStoryVisibleUncached 960ms 1.1s 184ms 0.2 16.1%
devStoryVisible 567ms 663ms 96ms -0.04 14.5%
devAutodocsVisible 464ms 573ms 109ms 0.21 19%
devMDXVisible 470ms 571ms 101ms 0.46 17.7%
buildManagerHeaderVisible 490ms 564ms 74ms -0.29 13.1%
buildManagerIndexVisible 503ms 583ms 80ms -0.24 13.7%
buildStoryVisible 492ms 561ms 69ms -0.32 12.3%
buildAutodocsVisible 414ms 520ms 106ms 0.57 20.4%
buildMDXVisible 437ms 485ms 48ms 0.07 9.9%

Greptile Summary

Removed duplicate comment line in the getSelectedParams function within the Next.js app router provider to improve code readability.

  • Removed redundant comment "Ensure catchAll and optional catchall are turned into an array" from code/frameworks/nextjs/src/routing/app-router-provider.tsx

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@DoHi0512 DoHi0512 closed this Oct 29, 2024
@DoHi0512 DoHi0512 reopened this Oct 29, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DoHi0512, thanks for putting together this pull request and helping us improve Storybook by catching this small item. We appreciate it 🙏 !

I've checked and all is good on our end. I'll gladly merge this once the checklist clears.

Hope you have a fantastic day.

Stay safe

Copy link

nx-cloud bot commented Nov 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5a56626. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes changed the title Cleanup: Remove duplicate comments Next.js: Remove duplicate comments Nov 4, 2024
@jonniebigodes
Copy link
Contributor

Going to merge this as the failures seem unrelated to the changes (only removing duplicate code comments).

@jonniebigodes jonniebigodes merged commit b0b5dde into storybookjs:next Nov 4, 2024
6 of 9 checks passed
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
6 tasks
@shilman shilman added cleanup Minor cleanup style change that won't show up in release changelog documentation and removed cleanup Minor cleanup style change that won't show up in release changelog labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants