Nextjs-Vite: Re-export vite-plugin-storybook-nextjs #29012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
feature request
nextjs
ci:daily
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f945473. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
approved these changes
Aug 30, 2024
yannbf
reviewed
Aug 30, 2024
| @@ -0,0 +1,3 @@ | |||
| import vitePluginStorybookNextJs from 'vite-plugin-storybook-nextjs'; | |||
There was a problem hiding this comment.
I assume in the future we also want to move the contents of the package into the monorepo?
yannbf
reviewed
Aug 30, 2024
valentinpalkovic
force-pushed
the
valentin/re-export-next-js-vite-plugin
branch
from
a2601ad
to
295bf1d
Compare
shilman
reviewed
Sep 2, 2024
valentinpalkovic
force-pushed
the
valentin/re-export-next-js-vite-plugin
branch
from
295bf1d
to
dea51a7
Compare
yannbf
approved these changes
Sep 2, 2024
valentinpalkovic
requested review from
kylegach and
jonniebigodes
as code owners
9 tasks
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
9 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+6
to
+7
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore |
There was a problem hiding this comment.
style: Consider removing the @ts-ignore and properly typing the module declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
I have re-exported
vite-plugin-storybook-nextjsfrom@storybook/experimental-nextjs-viteChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-29012-sha-f9454736. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29012-sha-f9454736 sandboxor in an existing project withnpx storybook@0.0.0-pr-29012-sha-f9454736 upgrade.More information
0.0.0-pr-29012-sha-f9454736valentin/re-export-next-js-vite-pluginf94547361725265078)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29012Greptile Summary
This PR re-exports the
vite-plugin-storybook-nextjsfrom@storybook/experimental-nextjs-vite, simplifying the setup process for Next.js users with Vite in Storybook projects.code/frameworks/experimental-nextjs-vite/src/vite-plugin/index.tsto re-export the plugin asstorybookNextJsPlugincode/frameworks/experimental-nextjs-vite/package.jsonto include the plugin as a dependencycode/addons/vitest/src/postinstall.tsto use the re-exported plugin for Next.js configurationvite-plugin-storybook-nextjsfrom extra dependencies incode/lib/cli-storybook/src/sandbox-templates.tsdocs/api/portable-stories/portable-stories-vitest.mdxto reflect the new import path