Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPC: Correct path to the @storybook/theming/create alias #28643

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

Averethel
Copy link
Contributor

@Averethel Averethel commented Jul 18, 2024

Closes #28566

What I did

The path to the @storybook/theming/create included package.json which made it impossible to resolve the alias.

Before

 '@storybook/theming/create': '<localPath>/node_modules/storybook/package.json/core/theming/create.js',

After

 '@storybook/theming/create': '<localPath>/node_modules/storybook/core/theming/create.js',

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  • integrate storybook in a project
  • create a custom theme
  • it should work now

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.5 MB 76.5 MB 248 B 1.09 0%
initSize 198 MB 198 MB -13 kB -0.3 0%
diffSize 121 MB 121 MB -13.3 kB -0.32 0%
buildSize 7.6 MB 7.59 MB -2.45 kB -0.09 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B 1.97 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.3 MB 2.3 MB -2.45 kB -0.33 -0.1%
buildSbPreviewSize 349 kB 349 kB 0 B 2 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB -2.45 kB -0.13 -0.1%
buildPreviewSize 3.12 MB 3.12 MB 0 B 1.73 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 7.2s 23.1s 15.8s 1.53 🔺68.5%
generateTime 23.1s 21s -2s -87ms -0.77 -9.9%
initTime 24s 22.3s -1s -673ms -0.66 -7.5%
buildTime 15.2s 16.3s 1.1s 1.57 🔺7.1%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 7.8s 8.7s 907ms 0.24 10.4%
devManagerResponsive 5.2s 5.6s 433ms -0.02 7.6%
devManagerHeaderVisible 740ms 926ms 186ms 2.34 🔺20.1%
devManagerIndexVisible 776ms 965ms 189ms 2.53 🔺19.6%
devStoryVisibleUncached 1.3s 1.2s -149ms -0.24 -11.9%
devStoryVisible 797ms 987ms 190ms 2.48 🔺19.3%
devAutodocsVisible 687ms 832ms 145ms 1.3 🔺17.4%
devMDXVisible 686ms 750ms 64ms 0.24 8.5%
buildManagerHeaderVisible 744ms 937ms 193ms 1.48 🔺20.6%
buildManagerIndexVisible 746ms 944ms 198ms 1.45 🔺21%
buildStoryVisible 793ms 991ms 198ms 1.39 🔺20%
buildAutodocsVisible 664ms 794ms 130ms 0.46 16.4%
buildMDXVisible 728ms 1s 347ms 6.07 🔺32.3%

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Fixed incorrect path for @storybook/theming/create alias
  • Removed package.json from alias path for better resolution

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ndelangen ndelangen self-assigned this Jul 19, 2024
@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Jul 19, 2024
@ndelangen ndelangen changed the title fix: correct path to the @storybook/theming/create alias CPC: Correct path to the @storybook/theming/create alias Jul 19, 2024
Copy link

nx-cloud bot commented Jul 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 57d0cd7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

The path to the `@storybook/theming/create` included `package.json` which made it impossible to resolve the alias.

```
 '@storybook/theming/create': '<localPath>/node_modules/storybook/package.json/core/theming/create.js',
```

 '@storybook/theming/create': '<localPath>/node_modules/storybook/core/theming/create.js',
@Averethel
Copy link
Contributor Author

@ndelangen extra comma slipped in the GitHub in-lint editing. It's fixed now and the build passes locally

@ndelangen ndelangen merged commit 4ea0e0c into storybookjs:next Jul 19, 2024
48 of 49 checks passed
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
CPC: Correct path to the `@storybook/theming/create` alias
(cherry picked from commit 4ea0e0c)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
CPC: Correct path to the `@storybook/theming/create` alias
(cherry picked from commit 4ea0e0c)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
CPC: Correct path to the `@storybook/theming/create` alias
(cherry picked from commit 4ea0e0c)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
CPC: Correct path to the `@storybook/theming/create` alias
(cherry picked from commit 4ea0e0c)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
CPC: Correct path to the `@storybook/theming/create` alias
(cherry picked from commit 4ea0e0c)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
CPC: Correct path to the `@storybook/theming/create` alias
(cherry picked from commit 4ea0e0c)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/theming/create export no longer exists with 8.2.2
2 participants