-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Make sure StorybookError message shows up in browser console and interactions panel #28464
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
71989a3
Proposal
kasperpeulen 0bd760a
migrate all errors to the new format
yannbf d65b117
rename template to message
yannbf ea9dd8c
update error docs
yannbf 4e4e6c0
fix eslint issues and migrate detection to the new error format
yannbf f54e780
update NoStoryMountedError error
yannbf 9d1b00c
Merge branch 'next' into kasper/error-handling
kasperpeulen 5dc7c1d
Fix wrong refactor
kasperpeulen a0f8189
Seems like a wrong refactor
kasperpeulen 93002de
Revert dedent import
kasperpeulen 19fbf2f
Fix indent
kasperpeulen d81bba3
Align templates and address feedback
kasperpeulen 13338a2
Adress feedback and fix unit test
kasperpeulen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix eslint issues and migrate detection to the new error format
- Loading branch information
commit 4e4e6c0466b62f4c3629c8bda133c65d296b35df
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧠 logic: Potential issue if
properties.category
orproperties.code
is null. Consider adding a null check.