Tags: Fix composition with older storybooks #27358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a6bdab7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
I think you would like to bump the index here as well: https://github.com/storybookjs/storybook/blob/next/code/lib/preview-api/src/modules/store/StoryIndexStore.ts#L27. Potentially, all places can refer to the same variable, so that this will not been overseen again |
storybook-bot
pushed a commit
that referenced
this pull request
May 24, 2024
…position Tags: Fix composition with older storybooks (cherry picked from commit fc915d6)
Merged
13 tasks
storybook-bot
pushed a commit
that referenced
this pull request
May 24, 2024
…position Tags: Fix composition with older storybooks (cherry picked from commit fc915d6)
25 tasks
storybook-bot
pushed a commit
that referenced
this pull request
May 24, 2024
…position Tags: Fix composition with older storybooks (cherry picked from commit fc915d6)
storybook-bot
pushed a commit
that referenced
this pull request
May 27, 2024
…position Tags: Fix composition with older storybooks (cherry picked from commit fc915d6)
2 tasks
storybook-bot
pushed a commit
that referenced
this pull request
May 27, 2024
…position Tags: Fix composition with older storybooks (cherry picked from commit fc915d6)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27352
What I did
Starting in 8.1, all stories get the
devtag by default and users have to opt-out if they want to hide them from the sidebar. Unfortunately, previous versions of Storybook did not add thedevtag by default, so those stories would be filtered from the sidebar when composed.We don't know the version of the Storybook we're composing, so instead I bumped the index version. When we compose a Storybook with a lower index version, we automatically add the
devtag to all stories.react-vite/devault-ts)Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
To test this fix by hand, fire up the
react-vite/default-ts(or navigate to it from the CI results) and verify by hand that:🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>