Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: Fix reference error when using re-exports with "vue-component-meta" #26303

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

larsrickert
Copy link
Contributor

Closes #26179

What I did

Fix reference errors when generating docinfo with the new vue-component-meta docgen plugin.
The issue occurred when using re-exports in .ts files (example below) that is then used inside Vue components.

export * from "./some-file";

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Clone the repository mentioned in the issue report
  2. Run pnpm install
  3. Run pnpm storybook
  4. Open http://localhost:6006/?path=/docs/%E5%85%AC%E5%85%B1%E7%BB%84%E4%BB%B6-drawer-drawer--docs

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@larsrickert larsrickert changed the title Vue: prevent reference error when using re-exports with "vue-component-meta" Vue: fix reference error when using re-exports with "vue-component-meta" Mar 4, 2024
@larsrickert larsrickert changed the title Vue: fix reference error when using re-exports with "vue-component-meta" Vue: Fix reference error when using re-exports with "vue-component-meta" Mar 4, 2024
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kasperpeulen kasperpeulen merged commit 489eba2 into next Mar 6, 2024
63 of 75 checks passed
@kasperpeulen kasperpeulen deleted the fix/26179-vue-component-meta-reference branch March 6, 2024 08:20
@github-actions github-actions bot mentioned this pull request Mar 6, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ReferenceError in 8.0.0-beta.5 when using docgen: "vue-component-meta"
2 participants