Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Remove qs from @storybook/manager-api & @storybook/channels #26285

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Mar 2, 2024

This removes the qs dependency from the manager-api and channels packages, instead using URLSearchParams (native functionality).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

N/A - should be covered enough in automated tests

This removes the `qs` dependency from the `manager-api` and `channels`
packages, instead using `URLSearchParams` (native functionality).
@ndelangen ndelangen changed the title chore: remove qs dependency from manager-api & channels Dependencies: Remove qs from @storybook/manager-api & @storybook/channels Mar 6, 2024
@ndelangen
Copy link
Member

@43081j This is great! Thank you for this!

I invited you to become a member of the org. I'd be wonderful to get more wins like this 🎉

Copy link

nx-cloud bot commented Mar 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e467a0e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@43081j
Copy link
Contributor Author

43081j commented Mar 6, 2024

thanks for the quick review 🙏

i want to get around to the other qs dependents too individually, though some are more complex but we'll see how it goes

& of course thank you for the invite to the org 🥳

@ndelangen ndelangen merged commit e87d043 into storybookjs:next Mar 7, 2024
47 checks passed
@43081j 43081j deleted the qs-part-1 branch March 7, 2024 08:57
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants