Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable Stories: Add support for Playwright CT in Vue3 #26198

Merged
merged 25 commits into from
Mar 18, 2024

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Feb 26, 2024

Closes #26192

TODO

  • Test slots/children in PW
  • Fix types for ComposedStory

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Covered by the Vue+PW test storybooks.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

socket-security bot commented Feb 26, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@JReinhold JReinhold self-assigned this Feb 26, 2024
@JReinhold JReinhold marked this pull request as ready for review February 26, 2024 13:32
@JReinhold JReinhold marked this pull request as draft February 28, 2024 14:46
@JReinhold
Copy link
Contributor Author

The tests are failing here because they need the fix to annotation-merging from #26267

@JReinhold JReinhold marked this pull request as ready for review March 1, 2024 12:44
Copy link

nx-cloud bot commented Mar 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d67ef70. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf merged commit f0dfc2a into feature/portable-stories-improvements Mar 18, 2024
8 checks passed
@yannbf yannbf deleted the jeppe/vue-pw-ct branch March 18, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants